Skip to content

fix: Backspace/enter behaviour in empty block with children#2451

Merged
matthewlipski merged 2 commits intomainfrom
empty-block-keyboard-fix
Feb 20, 2026
Merged

fix: Backspace/enter behaviour in empty block with children#2451
matthewlipski merged 2 commits intomainfrom
empty-block-keyboard-fix

Conversation

@matthewlipski
Copy link
Collaborator

@matthewlipski matthewlipski commented Feb 13, 2026

Summary

There are currently 2 issues with backspace/enter handling in empty blocks with children:

  • When pressing enter, a new block is created and the selection is moved to it, but the child blocks are not moved to it.
  • When pressing backspace, if the previous block is also empty, the child blocks are deleted instead of being un-nested.

Closes #1593

Rationale

This is a bug affecting core functionality.

Changes

Added handling for children in relevnt keyboard handlers.

Impact

N/A

Testing

Added e2e tests.

Screenshots/Video

Checklist

  • Code follows the project's coding standards.
  • Unit tests covering the new feature have been added.
  • All existing tests pass.
  • The documentation has been updated to reflect the new feature

Additional Notes

@vercel
Copy link

vercel bot commented Feb 13, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
blocknote Ready Ready Preview Feb 20, 2026 0:22am
blocknote-website Ready Ready Preview Feb 20, 2026 0:22am

Request Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 13, 2026

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/ariakit@2451

@blocknote/code-block

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/code-block@2451

@blocknote/core

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/core@2451

@blocknote/mantine

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/mantine@2451

@blocknote/react

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/react@2451

@blocknote/server-util

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/server-util@2451

@blocknote/shadcn

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/shadcn@2451

@blocknote/xl-ai

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-ai@2451

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-docx-exporter@2451

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-email-exporter@2451

@blocknote/xl-multi-column

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-multi-column@2451

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-odt-exporter@2451

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-pdf-exporter@2451

commit: c37bb5e

@nperez0111
Copy link
Contributor

nperez0111 commented Feb 17, 2026

@matthewlipski it's good that we don't lose content anymore, but in this case, I find the result unexpected, I would expect the item to preserve it's indentation not collapse because I removed the empty line
https://github.com/user-attachments/assets/178cad72-f2ed-4d05-b521-83e8ec32cea5

nperez0111
nperez0111 reviewed Feb 17, 2026
View reviewed changes
Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine, could do with some comments since this is a bit convoluted

@matthewlipski
Copy link
Collaborator Author

matthewlipski commented Feb 17, 2026

@matthewlipski it's good that we don't lose content anymore, but in this case, I find the result unexpected, I would expect the item to preserve it's indentation not collapse because I removed the empty line https://github.com/user-attachments/assets/178cad72-f2ed-4d05-b521-83e8ec32cea5

Ah, so I do kind of agree but this is the same behaviour as Notion, so imo it's better to keep it the way it is:

Screen.Recording.2026-02-17.at.16.57.40.mov

@nperez0111
Copy link
Contributor

nperez0111 commented Feb 17, 2026 •
edited
Loading

It handles list items differently. So weird decision on their part, imo I would prefer what I'd described, but doesn't have to block this issue if you feel differently

@matthewlipski
Copy link
Collaborator Author

matthewlipski commented Feb 20, 2026

@nperez0111 could you show what you mean with list items being handled differently? It seems to work the same for all block types as far as I can tell, but I might be missing something

Screen.Recording.2026-02-20.at.10.41.10.mov

@nperez0111
Copy link
Contributor

nperez0111 commented Feb 20, 2026

Screen.Recording.2026-02-20.at.10.54.29.mov

This is what I mean

@matthewlipski
Copy link
Collaborator Author

matthewlipski commented Feb 20, 2026

Ok this is indeed a really weird choice from their side. I think for this PR, I'll keep the logic as is. If people end up filing issues that this is unexpected behaviour, changing it to preserve child block nesting should take not much effort. Will also add comments.

@nperez0111
Copy link
Contributor

nperez0111 commented Feb 20, 2026

Fine with me @matthewlipski

@matthewlipski matthewlipski merged commit aa159a6 into main Feb 20, 2026
4 of 6 checks passed
@matthewlipski matthewlipski deleted the empty-block-keyboard-fix branch February 20, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nperez0111 nperez0111 nperez0111 left review comments

Assignees

@matthewlipski matthewlipski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Backspace on empty block before indented block delete both blocks

2 participants

@matthewlipski @nperez0111

Comments